Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pubsub: Use kwargs in test_subscriber_client #8414

Merged
merged 2 commits into from
Jun 19, 2019
Merged

Pubsub: Use kwargs in test_subscriber_client #8414

merged 2 commits into from
Jun 19, 2019

Conversation

dgorelik
Copy link
Contributor

This prevents test failures in case the ordering of the keyword arguments to the StreamingPullManager.open is switched

@dgorelik
Use kwargs in test_subscriber_client
c44f61e 
This prevents test failures in case the ordering of the keyword arguments to the `StreamingPullManager.open` is switched
@dgorelik
Merge pull request #1 from dgorelik/dgorelik-patch-1
26de36d 
Use kwargs in test_subscriber_client
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 18, 2019
@tseaver tseaver changed the title Use kwargs in test_subscriber_client Pubsub: Use kwargs in test_subscriber_client Jun 18, 2019
plamut
plamut approved these changes Jun 19, 2019
View reviewed changes
Copy link
Contributor

@plamut plamut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@plamut plamut merged commit 126474c into googleapis:master Jun 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@plamut plamut plamut approved these changes

@anguillanneuf anguillanneuf Awaiting requested review from anguillanneuf

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dgorelik @plamut @googlebot